mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

android: Move game deserialization to another thread

Browse source 
Deserializing games from the cache in shared preferences was done on the main thread and could cause a stutter on startup.
This commit is contained in:
Charles Lombardo 2023-10-29 14:15:37 -04:00
parent 911d2216be
commit 2581590023
1 changed files with 23 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/android/app/src/main/java/org/yuzu/yuzu_emu/model/GamesViewModel.kt
View file

@ -49,26 +49,33 @@ class GamesViewModel : ViewModel() {
// Retrieve list of cached games // Retrieve list of cached games
val storedGames = PreferenceManager.getDefaultSharedPreferences(YuzuApplication.appContext) val storedGames = PreferenceManager.getDefaultSharedPreferences(YuzuApplication.appContext)
.getStringSet(GameHelper.KEY_GAMES, emptySet()) .getStringSet(GameHelper.KEY_GAMES, emptySet())
if (storedGames!!.isNotEmpty()) {
val deserializedGames = mutableSetOf<Game>()
storedGames.forEach {
val game: Game
try {
game = Json.decodeFromString(it)
} catch (e: MissingFieldException) {
return@forEach
}
val gameExists = viewModelScope.launch {
DocumentFile.fromSingleUri(YuzuApplication.appContext, Uri.parse(game.path)) withContext(Dispatchers.IO) {
?.exists() if (storedGames!!.isNotEmpty()) {
if (gameExists == true) { val deserializedGames = mutableSetOf<Game>()
deserializedGames.add(game) storedGames.forEach {
val game: Game
try {
game = Json.decodeFromString(it)
} catch (e: MissingFieldException) {
return@forEach
}
val gameExists =
DocumentFile.fromSingleUri(
YuzuApplication.appContext,
Uri.parse(game.path)
)?.exists()
if (gameExists == true) {
deserializedGames.add(game)
}
}
setGames(deserializedGames.toList())
} }
reloadGames(false)
} }
setGames(deserializedGames.toList())
} }
reloadGames(false)
} }
fun setGames(games: List<Game>) { fun setGames(games: List<Game>) {