From ca20f359b575a840e62e3bb21b75ccd58ef5ad9c Mon Sep 17 00:00:00 2001
From: Jakob Bornecrantz <jakob@collabora.com>
Date: Wed, 16 Nov 2022 21:13:13 +0000
Subject: [PATCH] ipc: Allow UWP/AppContainer and others to connect

Including: UWP/AppContainer, Authenticated user and Administrator. Currently
guarded with IPC_RELAXED_CONNECTION_SECURITY env variable.
---
 scripts/monado-codespell.exclude              |  1 +
 .../server/ipc_server_mainloop_windows.cpp    | 58 ++++++++++++++++++-
 2 files changed, 58 insertions(+), 1 deletion(-)

diff --git a/scripts/monado-codespell.exclude b/scripts/monado-codespell.exclude
index 46dd1a137..ba646cecc 100644
--- a/scripts/monado-codespell.exclude
+++ b/scripts/monado-codespell.exclude
@@ -5,3 +5,4 @@
 #include <Unknwn.h>
 #include <asm/byteorder.h>
 	if (stream.parm.capture.capability & V4L2_CAP_TIMEPERFRAME) {
+	    TEXT("(A;OICI;GA;;;BA)");    // Administrator: full control
diff --git a/src/xrt/ipc/server/ipc_server_mainloop_windows.cpp b/src/xrt/ipc/server/ipc_server_mainloop_windows.cpp
index ac4e9a5b4..fb641625a 100644
--- a/src/xrt/ipc/server/ipc_server_mainloop_windows.cpp
+++ b/src/xrt/ipc/server/ipc_server_mainloop_windows.cpp
@@ -26,11 +26,24 @@
 #include "util/u_debug.h"
 #include "util/u_trace_marker.h"
 #include "util/u_file.h"
+#include "util/u_windows.h"
 
 #include "shared/ipc_shmem.h"
 #include "server/ipc_server.h"
 
 #include <conio.h>
+#include <sddl.h>
+
+
+/*
+ *
+ * Helpers.
+ *
+ */
+
+#define ERROR_STR(BUF, ERR) (u_winerror(BUF, ARRAY_SIZE(BUF), ERR, true))
+
+DEBUG_GET_ONCE_BOOL_OPTION(relaxed, "IPC_RELAXED_CONNECTION_SECURITY", false)
 
 
 /*
@@ -42,6 +55,42 @@
 static bool
 create_pipe_instance(struct ipc_server_mainloop *ml, bool first)
 {
+	SECURITY_ATTRIBUTES sa{};
+	sa.nLength = sizeof(sa);
+	sa.lpSecurityDescriptor = nullptr;
+	sa.bInheritHandle = FALSE;
+
+	/*
+	 * Change the pipe's DACL to allow other users access.
+	 *
+	 * https://learn.microsoft.com/en-us/windows/win32/secbp/creating-a-dacl
+	 * https://learn.microsoft.com/en-us/windows/win32/secauthz/sid-strings
+	 */
+	const TCHAR *str =               //
+	    TEXT("D:")                   // Discretionary ACL
+	    TEXT("(D;OICI;GA;;;BG)")     // Guest: deny
+	    TEXT("(D;OICI;GA;;;AN)")     // Anonymous: deny
+	    TEXT("(A;OICI;GRGWGX;;;AC)") // UWP/AppContainer packages: read/write/execute
+	    TEXT("(A;OICI;GRGWGX;;;AU)") // Authenticated user: read/write/execute
+	    TEXT("(A;OICI;GA;;;BA)");    // Administrator: full control
+
+	BOOL bret = ConvertStringSecurityDescriptorToSecurityDescriptor( //
+	    str,                                                         // StringSecurityDescriptor
+	    SDDL_REVISION_1,                                             // StringSDRevision
+	    &sa.lpSecurityDescriptor,                                    // SecurityDescriptor
+	    NULL);                                                       // SecurityDescriptorSize
+	if (!bret) {
+		DWORD err = GetLastError();
+		char buffer[1024];
+		U_LOG_E("ConvertStringSecurityDescriptorToSecurityDescriptor: %u %s", err, ERROR_STR(buffer, err));
+	}
+
+	LPSECURITY_ATTRIBUTES lpsa = nullptr;
+	if (debug_get_bool_option_relaxed()) {
+		U_LOG_W("Using relax security permissions on pipe");
+		lpsa = &sa;
+	}
+
 	DWORD dwOpenMode = PIPE_ACCESS_DUPLEX;
 	DWORD dwPipeMode = PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_NOWAIT | PIPE_REJECT_REMOTE_CLIENTS;
 
@@ -57,7 +106,14 @@ create_pipe_instance(struct ipc_server_mainloop *ml, bool first)
 	    IPC_BUF_SIZE,                   //
 	    IPC_BUF_SIZE,                   //
 	    0,                              //
-	    nullptr);                       //
+	    lpsa);                          //
+
+	if (sa.lpSecurityDescriptor != nullptr) {
+		// Need to free the security descriptor.
+		LocalFree(sa.lpSecurityDescriptor);
+		sa.lpSecurityDescriptor = nullptr;
+	}
+
 	if (ml->pipe_handle != INVALID_HANDLE_VALUE) {
 		return true;
 	}