mirrors/monado
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/monado/monado.git synced 2025-01-01 04:36:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

st/gui: Improve thread safety, improve comments and spelling

Browse source
This commit is contained in:
Jakob Bornecrantz 2023-09-21 15:10:48 +01:00
parent 53f510e6b9
commit bde2dce2b6
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/xrt/state_trackers/gui/gui_ogl_sink.c
View file

@ -117,19 +117,31 @@ gui_ogl_sink_update(struct gui_ogl_texture *tex)
struct gui_ogl_sink *s = container_of(tex, struct gui_ogl_sink, tex);
(void)s;
// Take the frame no need to adjust reference.
pthread_mutex_lock(&s->mutex);
struct xrt_frame *frame = s->frame;
s->frame = NULL;
struct xrt_frame *frame = NULL;
// Only take the frame if we are running.
if (s->running) {
// Take the frame no need to adjust reference.
frame = s->frame;
s->frame = NULL;
}
pthread_mutex_unlock(&s->mutex);
if (frame == NULL) {
return;
}
// To large stride for GLint.
/*
* The frame properties are immutable while it is alive,
* so no need to take any locks while reading them.
*/
// Too large of stride for GLint.
if (frame->stride > INT_MAX) {
U_LOG_E("Stride unreasonable large!");
U_LOG_E("Stride unreasonably large!");
return;
}