From 7a4ba078d9e1adda8a956e40d3ef5183079169ab Mon Sep 17 00:00:00 2001 From: Rylie Pavlik Date: Tue, 5 Nov 2024 12:41:08 -0600 Subject: [PATCH] a/vk: Add/update comments Part-of: --- src/xrt/auxiliary/vk/vk_helpers.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/xrt/auxiliary/vk/vk_helpers.c b/src/xrt/auxiliary/vk/vk_helpers.c index ad7eda811..f18c78f6f 100644 --- a/src/xrt/auxiliary/vk/vk_helpers.c +++ b/src/xrt/auxiliary/vk/vk_helpers.c @@ -1063,6 +1063,13 @@ err_image: return ret; } +// - vk_csci_get_image_external_handle_type (usually but not always a constant) +// - vk_csci_get_image_external_support +// - vkGetPhysicalDeviceImageFormatProperties2 +// - vkCreateImage +// - vkGetImageMemoryRequirements +// - maybe vkGetAndroidHardwareBufferPropertiesANDROID +// - vk_alloc_and_bind_image_memory XRT_CHECK_RESULT VkResult vk_create_image_from_native(struct vk_bundle *vk, const struct xrt_swapchain_create_info *info, @@ -1078,13 +1085,13 @@ vk_create_image_from_native(struct vk_bundle *vk, #ifdef XRT_GRAPHICS_BUFFER_HANDLE_IS_AHARDWAREBUFFER /* * Some Vulkan drivers will natively support importing and exporting - * SRGB formats (Qualcomm Adreno) even tho technically that's not intended - * by the AHardwareBuffer since they don't support sRGB formats. - * While others (arm Mali) does not support importing and exporting sRGB - * formats. So we need to create the image without sRGB and then create - * the image views with sRGB which is allowed by the Vulkan spec. It - * seems to be safe to do with on all drivers, so to reduce the logic - * do that instead. + * SRGB formats (Qualcomm Adreno) even though technically the + * AHardwareBuffer support for sRGB is... awkward (not inherent). + * While others (arm Mali) does not support importing and exporting + * sRGB formats. So we need to create the image without sRGB and + * then create the image views with sRGB which is allowed by the + * Vulkan spec. It seems to be safe to do with on all drivers, + * so to reduce the logic do that instead. */ if (image_format == VK_FORMAT_R8G8B8A8_SRGB) { image_format = VK_FORMAT_R8G8B8A8_UNORM;