settings: only store settings if changed by user

web/src/lib/settings.ts

@@ -4,9 +4,11 @@ import { merge } from 'ts-deepmerge';
 import type { RecursivePartial } from './types/generic';
 import type { CobaltSettings } from './types/settings';
 
-import defaultSettings from "$lib/settings/defaults";
+import defaultSettings from './settings/defaults';
 
-const writeToStorage = (settings: CobaltSettings) => {
+type PartialSettings = RecursivePartial<CobaltSettings>;
+
+const writeToStorage = (settings: PartialSettings) => {
     localStorage.setItem(
         "settings",
         JSON.stringify(settings)
@@ -18,28 +20,31 @@ const writeToStorage = (settings: CobaltSettings) => {
 const loadFromStorage = () => {
     const settings = localStorage.getItem('settings');
     if (!settings) {
-        return defaultSettings;
+        return {};
     }
 
-    return {
+    return JSON.parse(settings) as PartialSettings;
-        ...defaultSettings,
-        ...JSON.parse(settings) as CobaltSettings
-    }
 }
 
 let update: (_: Updater<CobaltSettings>) => void;
 
+// deep merge partial type into full CobaltSettings type
+const mergeWithDefaults = (partial: PartialSettings) => {
+    return merge(defaultSettings, partial) as CobaltSettings;
+}
+
 export default readable<CobaltSettings>(
-    loadFromStorage(),
+    mergeWithDefaults(loadFromStorage()),
     (_, _update) => { update = _update }
 );
 
 // update settings from outside
-export function updateSetting(settings: RecursivePartial<CobaltSettings>) {
+export function updateSetting(partial: PartialSettings) {
-    update((current) => {
+    update(() => {
-        // deep merge partial type into full CobaltSettings type
+        const updated = writeToStorage(
-        current = merge(current, settings) as CobaltSettings;
+            merge(loadFromStorage(), partial)
+        );
 
-        return writeToStorage(current);
+        return mergeWithDefaults(updated);
     });
 }