From 55c5fc482c9a8dc2f714d5d660ae4cab66686672 Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Wed, 27 Sep 2023 18:20:34 +0000 Subject: [PATCH] refactor: refactor unnecessary `else` / `elif` when `if` block has a `return` statement The use of `else` or `elif` becomes redundant and can be dropped if the last statement under the leading `if` / `elif` block is a `return` statement. In the case of an `elif` after `return`, it can be written as a separate `if` block. For `else` blocks after `return`, the statements can be shifted out of `else`. Please refer to the examples below for reference. Refactoring the code this way can improve code-readability and make it easier to maintain. --- onlylegs/app.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/onlylegs/app.py b/onlylegs/app.py index 5e1e632..51bf25d 100644 --- a/onlylegs/app.py +++ b/onlylegs/app.py @@ -138,8 +138,7 @@ def handle_errors(): render_template("error.html", error=err.code, msg=err.description), err.code, ) - else: - return str(err.code) + ": " + err.description, err.code + return str(err.code) + ": " + err.description, err.code def register_blueprints():